Monday, January 09, 2012

ConnectionPool performance improvements

Hi, all!

Today I committed a change to Npgsql which will improve connection pool performance. This change was motivated by Andrew's bug report where he noticed that a lot of threads were waiting to get a new connection from pool.

In order to keep consistence of the pool, Npgsql has to lock access to it. Andrew's problem appeared in a busy server where a lot of threads were trying to get a new connection from the pool. They had to wait in line. And obviously this isn't good.

The current implementation of Npgsql creates a big lock surrounding all the code needed to work with the pool and more! As Andrew noticed in his bug report, I/O operations were being done inside this lock which was contributing to more delays to get a connection from the pool.

So, to fix that, I rewrote connection pool logic to remove this big lock and break it down to smaller ones only when really needed. All the I/O operations were left out of the locks, this way, other threads waiting to get a new connection from the pool don't need to wait for those expensive operations to finish.

I made a lot of tests and could confirm that when I break the code inside the debugger, threads are spread throughout connection pool code as expected instead of waiting in line on the big lock.

As this change is somewhat critical to Npgsql usage, I'd like to ask you to download the code, compile it and give it a try and see if everything is working ok or even better than before. I expect busy servers to be able to increase their raw throughput because it will have to wait less to get connections from the pool.

As always, please, let me know if you have any problems and all feedback is very welcome!


Bryan Murphy said...

Wow! Can't wait to try the new versions. The behavior has been giving us grief for months. We ended up solving it by simply making the connection pool much bigger than necessary.

Slava said...

this is really cool. thanks for working on it!

Bruno Lessa said...

Bom dia Francisco !

Me diz uma coisa essa modificacao ja está na 11.93 ?

Estou teno mtos problemas com o pool na minha aplicação. Ultimamente tenho que restartar o IIS para que para de dar too many clients already.

Será que aumentando o maxpoolsize , melhora ?

abraco !

Bruno Lessa said...

Bom dia Francisco.

Esta aleração já está na 11.93 ? É pq comecei a ter problemas com as conexões na minha app. Tenho as vezes que restartar o IIS para que volte a funcionar. Fica dando too many clients already direto.

Será que esta alteraç~çao resolve ? Ou entao aumentar o maxpoolsize ?

Abs !!!